This repository has been archived by the owner on Jul 25, 2023. It is now read-only.
#302: Introducing initial helm chart for aegis #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishek44sharma
force-pushed
the
topic/abhisheks2/302
branch
7 times, most recently
from
86fe5a0
to
d73ab02
Compare
Signed-off-by: Abhishek Sharma <abhisheks2@vmware.com>
abhishek44sharma
force-pushed
the
topic/abhisheks2/302
branch
from
d73ab02
to
4256f6e
Compare
|
Happy to announce that all tets passed on my end \o/ . |
v0lkan
reviewed
Jul 22, 2023
v0lkan
reviewed
Jul 22, 2023
v0lkan
reviewed
Jul 22, 2023
v0lkan
reviewed
Jul 22, 2023
v0lkan
reviewed
Jul 22, 2023
v0lkan
reviewed
Jul 22, 2023
v0lkan
suggested changes
Jul 22, 2023
There was a problem hiding this comment.
There is a .DS_Store file in ./charts if we can delete it, the rest is looking good.
I have some nit nitpick comments too, mosty about missing newlines and other cosmetic stuff. If we can add those during the process, that would be great too.
Other than that, great work 🤘.
Helm Charts FTW.
Signed-off-by: Abhishek Sharma <abhisheks2@vmware.com>
v0lkan
approved these changes
Jul 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing initial helm chart for aegis... Keep your secrets... secret