-
-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansi highlighting not working with theme dark-plus #597
Closed
5 tasks done
chwzr opened this issue
Feb 20, 2024
· 2 comments
· May be fixed by NOUIY/nodejs.org#1313, NOUIY/nodejs.org#1322, NOUIY/nodejs.org#1331, NOUIY/nodejs.org#1340 or NOUIY/nodejs.org#1349
Closed
5 tasks done
ansi highlighting not working with theme dark-plus #597
chwzr opened this issue
Feb 20, 2024
· 2 comments
· May be fixed by NOUIY/nodejs.org#1313, NOUIY/nodejs.org#1322, NOUIY/nodejs.org#1331, NOUIY/nodejs.org#1340 or NOUIY/nodejs.org#1349
Comments
Figured out that adding optional chaining operator to shiki/packages/core/src/utils.ts Lines 149 to 151 in b6d40a3
|
chwzr
added a commit
to chwzr/shiki
that referenced
this issue
Feb 20, 2024
I've implemented a PR for this. Please let me know if this fix is acceptable or if you think there is another way to fix it. |
diegohaz
referenced
this issue
in ariakit/ariakit
Mar 1, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [shiki](https://github.com/shikijs/shiki) ([source](https://github.com/shikijs/shiki/tree/HEAD/packages/shiki)) | [`1.1.6` -> `1.1.7`](https://renovatebot.com/diffs/npm/shiki/1.1.6/1.1.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/shiki/1.1.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/shiki/1.1.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/shiki/1.1.6/1.1.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/shiki/1.1.6/1.1.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>shikijs/shiki (shiki)</summary> ### [`v1.1.7`](https://github.com/shikijs/shiki/releases/tag/v1.1.7) [Compare Source](https://github.com/shikijs/shiki/compare/v1.1.6...v1.1.7) ##### 🐞 Bug Fixes - Allow nullish color for colorReplacement, fix ansi highlighting with dark-plus, fix [#​597](https://github.com/shikijs/shiki/issues/597) - by [@​chwzr](https://github.com/chwzr) in [https://github.com/shikijs/shiki/issues/598](https://github.com/shikijs/shiki/issues/598) and [https://github.com/shikijs/shiki/issues/597](https://github.com/shikijs/shiki/issues/597) [<samp>(ccb58)</samp>](https://github.com/shikijs/shiki/commit/ccb58331) ##### [View changes on GitHub](https://github.com/shikijs/shiki/compare/v1.1.6...v1.1.7) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
This was referenced May 18, 2024
This was referenced May 25, 2024
This was referenced Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Validations
Describe the bug
When using theme
dark-plus
and languageansi
together shiki fails to render anything with following error:Other themes are working fine (e.g. monokai). Included a simple Reproduction Code Sandbox.
Reproduction
https://codesandbox.io/p/sandbox/dark-plus-ansi-8qkpwj?file=%2Fsrc%2Findex.ts%3A1%2C1-20%2C1
Contributes
The text was updated successfully, but these errors were encountered: