New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escapeHtml bug fix #28

Merged

octref merged 1 commit into shikijs:master from jackens:escapeHtml_bug_fix

Aug 5, 2020

Contributor

jackens commented Feb 11, 2020

Conf. issue #26


          escapeHtml bug fix

ce14180

vfcp commented Jul 16, 2020

" characters should also be escaped to " and ' should be escaped to '

See https://github.com/component/escape-html/blob/b42947eefa79efff01b3fe988c4c7e7b051ec8d8/index.js#L33 as reference

Collaborator

octref commented Aug 5, 2020

@vfcp thanks for pointing it out. I'll clean it up after merging.

octref merged commit 7973326 into shikijs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet