fix(monaco): options for tokenize limit #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for shiki-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for shiki-matsu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
reviewed
Apr 17, 2024
docs/packages/monaco.md
Outdated
Comment on lines
42
to
45
| shikiToMonaco(highlighter, monaco, { | ||
| tokenizeMaxLineLength: 20000, | ||
| tokenizeTimeLimit: 500 | ||
| }) |
There was a problem hiding this comment.
I don't think we need to document it here as I consider those should be rarely used options. TypeScript should already do the work
There was a problem hiding this comment.
yes，I removed this part of the code in docs
antfu
changed the title
diegohaz
referenced
this pull request
in ariakit/ariakit
May 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [shiki](https://github.com/shikijs/shiki) ([source](https://github.com/shikijs/shiki/tree/HEAD/packages/shiki)) | [`1.3.0` -> `1.5.1`](https://renovatebot.com/diffs/npm/shiki/1.3.0/1.5.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>shikijs/shiki (shiki)</summary> ### [`v1.5.1`](https://github.com/shikijs/shiki/releases/tag/v1.5.1) [Compare Source](https://github.com/shikijs/shiki/compare/v1.5.0...v1.5.1) ##### 🐞 Bug Fixes - **core**: Simplify cloudflare wasm loading - by [@​hi-ogawa](https://github.com/hi-ogawa) in [https://github.com/shikijs/shiki/issues/670](https://github.com/shikijs/shiki/issues/670) [<samp>(cd239)</samp>](https://github.com/shikijs/shiki/commit/cd239324) ##### [View changes on GitHub](https://github.com/shikijs/shiki/compare/v1.5.0...v1.5.1) ### [`v1.5.0`](https://github.com/shikijs/shiki/releases/tag/v1.5.0) [Compare Source](https://github.com/shikijs/shiki/compare/v1.4.0...v1.5.0) ##### 🚀 Features - Upgrade deps, new langs - by [@​antfu](https://github.com/antfu) [<samp>(d5b04)</samp>](https://github.com/shikijs/shiki/commit/d5b04703) ##### [View changes on GitHub](https://github.com/shikijs/shiki/compare/v1.4.0...v1.5.0) ### [`v1.4.0`](https://github.com/shikijs/shiki/releases/tag/v1.4.0) [Compare Source](https://github.com/shikijs/shiki/compare/v1.3.0...v1.4.0) ##### 🚀 Features - Upgrade deps, new langs and themes - by [@​antfu](https://github.com/antfu) [<samp>(26f37)</samp>](https://github.com/shikijs/shiki/commit/26f37f08) ##### 🐞 Bug Fixes - **core**: Check existance of `Buffer.isBuffer`, fix [#​664](https://github.com/shikijs/shiki/issues/664) - by [@​NullVoxPopuli](https://github.com/NullVoxPopuli) in [https://github.com/shikijs/shiki/issues/666](https://github.com/shikijs/shiki/issues/666) and [https://github.com/shikijs/shiki/issues/664](https://github.com/shikijs/shiki/issues/664) [<samp>(86d52)</samp>](https://github.com/shikijs/shiki/commit/86d5271e) - **monaco**: Options for tokenize limit - by [@​hddhyq](https://github.com/hddhyq), [@​antfu](https://github.com/antfu) and **Anthony Fu** in [https://github.com/shikijs/shiki/issues/657](https://github.com/shikijs/shiki/issues/657) [<samp>(a606d)</samp>](https://github.com/shikijs/shiki/commit/a606d449) - **transformers**: Allow SQL comment syntax in notation transformer, fix [#​654](https://github.com/shikijs/shiki/issues/654) - by [@​senicko](https://github.com/senicko) in [https://github.com/shikijs/shiki/issues/655](https://github.com/shikijs/shiki/issues/655) and [https://github.com/shikijs/shiki/issues/654](https://github.com/shikijs/shiki/issues/654) [<samp>(cc135)</samp>](https://github.com/shikijs/shiki/commit/cc13539e) ##### [View changes on GitHub](https://github.com/shikijs/shiki/compare/v1.3.0...v1.4.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ariakit/ariakit). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM0MC4xMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced May 22, 2024
This was referenced May 30, 2024
This was referenced Jun 7, 2024
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add option to configure tokenizeMaxLineLength and tokenizeTimeLimit in @shikijs/monaco
Linked Issues
fix #625
Additional context