Release 1.0.0, compatible with Mobility 1.0 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shioyama
commented
Dec 17, 2020
| @@ -23,15 +23,16 @@ def included(model_class) | |||
|
|
|||
| mod = Module.new do | |||
| def friendly | |||
| super.send(::Mobility.query_method) | |||
| # TODO: Make this constant public in Mobility 1.1 so we don't need const_get | |||
| super.extending(::Mobility::Plugins::ActiveRecord::Query.const_get(:QueryExtension)) | |||
There was a problem hiding this comment.
Working on some changes to make more constants public from the query plugin: shioyama/mobility#471
I'll probably release shortly in a 1.1. Didn't want to include it in 1.0 to delay that release any longer. For now this should do.
shioyama
force-pushed
the
release_1_0
branch
4 times, most recently
from
51cf10e
to
b0b2817
Compare
shioyama
force-pushed
the
release_1_0
branch
from
b0b2817
to
e6f4496
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22