Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix event timing issue and add button for demo start #2980

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

chuckcarpenter
Copy link
Member

This branch fixes #2961 by changing the order of assigning the currentStep within a Tour and then fires 'show'.

Also, this adds a button do that the demo tour doesn't start automatically, it's opt in. (e.g., intro.js and driver.js site style)

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shepherd-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:51pm
shepherd-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 7:51pm

@chuckcarpenter chuckcarpenter merged commit a94cb39 into main Sep 20, 2024
8 of 9 checks passed
@chuckcarpenter chuckcarpenter deleted the feat/landing-demo-click branch September 20, 2024 19:55
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tour.getCurrentStep() returns null on the first step and returns the previous step for the subsequent steps
1 participant