Merge pull request #674 from ImJasonH/deprecate

Deprecate .status.succeeded and .status.reason

pkg/apis/build/v1alpha1/buildrun_types.go

@@ -45,19 +45,27 @@ type BuildRunSpec struct {
 
 // BuildRunStatus defines the observed state of BuildRun
 type BuildRunStatus struct {
-
-	// Conditions
+	// Conditions holds the latest available observations of a resource's current state.
 	Conditions Conditions `json:"conditions,omitempty"`
 
 	// The Succeeded status of the TaskRun
+	//
+	// Deprecated: Use Conditions instead. This will be removed in a future release.
+	//
 	// +optional
 	Succeeded corev1.ConditionStatus `json:"succeeded,omitempty"`
 
 	// The Succeeded reason of the TaskRun
+	//
+	// Deprecated: Use Conditions instead. This will be removed in a future release.
+	//
 	// +optional
 	Reason string `json:"reason,omitempty"`
 
-	// PodName is the name of the pod responsible for executing this task's steps.
+	// LatestTaskRunRef is the name of the TaskRun responsible for executing this BuildRun.
+	//
+	// TODO: This should be called something like "TaskRunName"
+	//
 	// +optional
 	LatestTaskRunRef *string `json:"latestTaskRunRef,omitempty"`
 

pkg/reconciler/buildrun/buildrun.go

@@ -218,10 +218,13 @@ func (r *ReconcileBuildRun) Reconcile(request reconcile.Request) (reconcile.Resu
 				}
 			}
 
+			//lint:ignore SA1019 should be set until removed
 			buildRun.Status.Succeeded = taskRunStatus
 			if taskRunStatus == corev1.ConditionFalse {
+				//lint:ignore SA1019 should be set until removed
 				buildRun.Status.Reason = trCondition.Message
 			} else {
+				//lint:ignore SA1019 should be set until removed
 				buildRun.Status.Reason = trCondition.Reason
 			}
 
@@ -380,7 +383,9 @@ func (r *ReconcileBuildRun) createTaskRun(ctx context.Context, build *buildv1alp
 // updateBuildRunErrorStatus updates buildRun status fields
 func (r *ReconcileBuildRun) updateBuildRunErrorStatus(ctx context.Context, buildRun *buildv1alpha1.BuildRun, errorMessage string) error {
 	// these two fields are deprecated and will be removed soon
+	//lint:ignore SA1019 should be set until removed
 	buildRun.Status.Succeeded = corev1.ConditionFalse
+	//lint:ignore SA1019 should be set until removed
 	buildRun.Status.Reason = errorMessage
 
 	now := metav1.Now()