Skip to content

Commit

Permalink
Update docs/proposals/env-vars.md
Browse files Browse the repository at this point in the history
Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
  • Loading branch information
gabemontero and SaschaSchwarze0 authored May 4, 2021
1 parent e63747e commit 4b7f905
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/proposals/env-vars.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ All of these features seem accessible to Shipwright, in that
from a [Build and BuildRun](https://github.com/shipwright-io/build/blob/v0.4.0/pkg/reconciler/buildrun/resources/taskrun.go#L175-L199)
- Tekton's TaskRun reconciler performs the parameter based variable substitution on the TaskRun/TaskSpec Steps/Containers
(the call stack is lengthy, so I won't post all the links here :-) )
- An implementation of Shipwright's [https://github.com/shipwright-io/build/pull/697/](https://github.com/shipwright-io/build/pull/697/) or
- An implementation of Shipwright's [Add EP on Build Strategies Parametrization #697](https://github.com/shipwright-io/build/pull/697) or
follow on that allows specification and mapping from Shipwright API to then perform the appropriate `TaskSpec` to `Step` [manipulation](https://github.com/shipwright-io/build/blob/v0.4.0/pkg/reconciler/buildrun/resources/taskrun.go#L129-L141).

Independent of fully integrating Shipwright with Tekton Parameterization, a first class API for environment variables
Expand Down

0 comments on commit 4b7f905

Please sign in to comment.