Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buildpacks strategy #1323

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Jun 19, 2023

Changes

This pull request updates several things in the Buildpacks strategy samples:

  • Heroku is updated to Ubuntu Bionic (22). This required a change in the sample as Heroku does now require a Procfile to define the entrypoint. The e2e can therefore only succeed after Add Procfile for Heroku example sample-nodejs#7 is merged.
  • The platform API is updated to 0.7. This includes the change to have analyze before detect
  • The layers and cache directories are changed to include a .shp directory in the path under /tmp. The reason is that /tmp/cache can be overlapping with a directory used by build tools.

Fixes #1280
Fixes #1295

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Buildpacks sample build strategies are updated to the latest Heroku version and a newer platform API version

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Jun 19, 2023
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee June 19, 2023 20:26
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems familiar.

nice

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Jun 20, 2023
@SaschaSchwarze0 SaschaSchwarze0 added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 20, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@qu1queee
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@qu1queee
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit f3e60a9 into shipwright-io:main Jun 24, 2023
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-buildpacks-updates branch August 21, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Heroku sample strategies to heroku-22 stack (Cluster)BuildStrategy CR about buildpacks are outdated
4 participants