Remove unused fields from GitSource

[imjasonh]

Fixes #682

Changes

Remove HTTPProxy, HTTPSProxy, NoProxy and Flavor. No other code referenced them, so if users set these fields they wouldn't have any effect.

/kind cleanup
/kind api-change

Submitter Checklist

• [n] Includes tests if functionality changed/was added
• [n] Includes docs if changes are user-facing
• [y] Set a kind label on this PR
• [y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Remove unused fields from GitSource

/assign @sbose78

[zhangtbj]

Yes, It is initialized by @sbose78 at the beginning.

But no implementation yet. If we don't have a plan to achieve it in the latest release or in 1.0.0, I also suggest remove it first.

[SaschaSchwarze0]

Interesting. Never saw them before.

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SaschaSchwarze0]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qu1queee]

/lgtm

[qu1queee]

oh damn, sorry I added/remove my looksgoodtome, it seems we want @sbose78 approval as he originally added this?

[SaschaSchwarze0]

oh damn, sorry I added/remove my looksgoodtome, it seems we want @sbose78 approval as he originally added this?

Is an API change. I think we then look for lgtm and approve to come from different companies. Although this one is not really an API change. It only removes what was never read by any controller anyway.

[gabemontero]

/lgtm

[sbose78]

Was an ambitious addition, let's remove it now. We'll probably not use the API when we actually implement this.