Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated .status.succeeded and .status.reason #725

Merged

Conversation

imjasonh
Copy link
Contributor

@imjasonh imjasonh commented Apr 9, 2021

Changes

These were deprecated in #674 and should be removed before the next release.

/kind cleanup

Submitter Checklist

  • [y] Includes tests if functionality changed/was added
  • [n] Includes docs if changes are user-facing
  • [y] Set a kind label on this PR
  • [y] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

The deprecated .status.succeeded and .status.reason fields are removed.

@openshift-ci-robot openshift-ci-robot added release-note Label for when a PR has specified a release note kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 9, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign otaviof after the PR has been reviewed.
You can assign the PR to them by writing /assign @otaviof in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@imjasonh imjasonh force-pushed the remove-deprecated branch 6 times, most recently from 1c192b5 to 7819dc2 Compare April 9, 2021 20:27
@SaschaSchwarze0
Copy link
Member

Maybe a topic for Monday @imjasonh, I would just leave these fields in and do a larger cleanup with v1beta1.

@zhangtbj
Copy link
Contributor

Just talked with our UX team, they will switch to the new condition property soon. We can double check with them next week to see when it can be ready.

Thanks for the exception! We will update once we have any news.

Also cc @qu1queee

1 similar comment
@zhangtbj
Copy link
Contributor

Just talked with our UX team, they will switch to the new condition property soon. We can double check with them next week to see when it can be ready.

Thanks for the exception! We will update once we have any news.

Also cc @qu1queee

@qu1queee
Copy link
Contributor

@imjasonh do you mind adding a do-not-merge/hold label?

@qu1queee qu1queee added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@qu1queee
Copy link
Contributor

qu1queee commented Apr 30, 2021

I think we will be able to merge this one soon. Downstream the teams are moving out of the deprecated fields by May 14th, or even before that. After that we should be able to merge this one. Sorry for the inconvenience.

@imjasonh
Copy link
Contributor Author

No worries! I'd rather take the time to make sure this doesn't cause any pain downstream. I'll be happy as long as it makes it into the next release or two, and we're well ahead of schedule on that.

@qu1queee qu1queee self-requested a review May 19, 2021 13:18
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long wait, as today we are finally ready for this deprecation in downstream.

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 19, 2021
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qu1queee
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
@imjasonh imjasonh removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2021
@openshift-merge-robot openshift-merge-robot merged commit 3571347 into shipwright-io:main May 19, 2021
@adambkaplan adambkaplan added this to the release-v0.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants