-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated .status.succeeded and .status.reason #725
Remove deprecated .status.succeeded and .status.reason #725
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1c192b5
to
7819dc2
Compare
Maybe a topic for Monday @imjasonh, I would just leave these fields in and do a larger cleanup with v1beta1. |
Just talked with our UX team, they will switch to the new condition property soon. We can double check with them next week to see when it can be ready. Thanks for the exception! We will update once we have any news. Also cc @qu1queee |
1 similar comment
Just talked with our UX team, they will switch to the new condition property soon. We can double check with them next week to see when it can be ready. Thanks for the exception! We will update once we have any news. Also cc @qu1queee |
@imjasonh do you mind adding a |
I think we will be able to merge this one soon. Downstream the teams are moving out of the deprecated fields by May 14th, or even before that. After that we should be able to merge this one. Sorry for the inconvenience. |
No worries! I'd rather take the time to make sure this doesn't cause any pain downstream. I'll be happy as long as it makes it into the next release or two, and we're well ahead of schedule on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long wait, as today we are finally ready for this deprecation in downstream.
/lgtm
/approve
7819dc2
to
33e01f8
Compare
33e01f8
to
3355aac
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Changes
These were deprecated in #674 and should be removed before the next release.
/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes