Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in reason, fix links #746

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Fix typo in reason, fix links #746

merged 1 commit into from
Apr 28, 2021

Conversation

SaschaSchwarze0
Copy link
Member

Changes

In the build documentation, we named the reason SpecSourceSecretNotFound, but actually is SpecSourceSecretRefNotFound. Also fixing the strategy table on that page where the ko link was broken and buildkit missing.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Correcting the SpecSourceSecretNotFound reason in the build documentation to SpecSourceSecretRefNotFound

@openshift-ci-robot openshift-ci-robot added the release-note Label for when a PR has specified a release note label Apr 28, 2021
@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Apr 28, 2021
@qu1queee qu1queee self-requested a review April 28, 2021 12:15
qu1queee
qu1queee approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@SaschaSchwarze0 SaschaSchwarze0 changed the title FIx typo in reason, fix links Fix typo in reason, fix links Apr 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit 5dbd283 into shipwright-io:master Apr 28, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-correct-reason branch April 28, 2021 13:06
@adambkaplan adambkaplan added this to the release-v0.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SaschaSchwarze0 @openshift-ci-robot @qu1queee @adambkaplan @openshift-merge-robot