Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin buildah version #749

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Apr 29, 2021

Changes

Our builds started failing during e2e with this failure in the buildah BuildRun:

Logs of container step-buildah-bud:
STEP 1: FROM golang:1.16 AS build
STEP 2: FROM scratch
error creating build container: short-name resolution enforced but cannot prompt without a TTY

Using v1.20.1 seems to work, though I have not found some commit in buildah yet that is problematic.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Use buildah v1.20.1 in the sample build strategies

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Label for when a PR has specified a release note labels Apr 29, 2021
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-buildah-pin-version branch 3 times, most recently from 7e7b40c to e8ebba4 Compare April 29, 2021 11:17
@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Apr 29, 2021
@SaschaSchwarze0 SaschaSchwarze0 changed the title WIP Pin buildah version Pin buildah version Apr 29, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2021
@SaschaSchwarze0 SaschaSchwarze0 requested review from qu1queee and removed request for zhangtbj April 29, 2021 12:47
@imjasonh
Copy link
Contributor

containers/buildah#3096 seems to be related FYI

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@gabemontero
Copy link
Member

Yeah we should avoid latest in general IMO across all the strategies and the images they use (though I have not looked to see if buildah is the only offender)

this is either a good start or the last piece of that solution :-)

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 78de60d into shipwright-io:master Apr 29, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-buildah-pin-version branch April 29, 2021 15:19
@adambkaplan adambkaplan added this to the release-v0.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants