Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jason as an approver #755

Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented May 4, 2021

Changes

Add Jason as an approver. Move zhangtbj to only reviewers.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Add ImJasonH as an approver for PRs

Move zhangtbj to only reviewers.
@qu1queee qu1queee added kind/documentation Categorizes issue or PR as related to documentation. kind/design Categorizes issue or PR as related to design. labels May 4, 2021
@openshift-ci-robot openshift-ci-robot added the release-note Label for when a PR has specified a release note label May 4, 2021
@qu1queee qu1queee changed the title Add Jason as an approver. Add Jason as an approver May 4, 2021
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@qu1queee qu1queee requested a review from adambkaplan May 4, 2021 11:05
@qu1queee
Copy link
Contributor Author

qu1queee commented May 4, 2021

@adambkaplan or @otaviof pls review this one.

@imjasonh
Copy link
Contributor

imjasonh commented May 4, 2021

/approve

😄

@otaviof
Copy link
Member

otaviof commented May 4, 2021

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imjasonh, otaviof, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SaschaSchwarze0,otaviof]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-merge-robot openshift-merge-robot merged commit 96fa3bb into shipwright-io:master May 4, 2021
@qu1queee qu1queee deleted the qu1queee/new_approvers branch May 4, 2021 14:46
@adambkaplan adambkaplan added this to the release-v0.5.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants