Mitigate context deadline exceeded issue #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the default implementation of `repo.List`, the timeout seems to be rather short and there are intermittent context deadline exceeded errors when running the unit tests under load, or when repeating them over and over again. Mitigate the error by switching to the list function that accepts a context. It was added recently and privides the possibility to define a different timeout. Refactor related code to make it more compact by removing superfluous returns.
openshift-ci-robot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
HeavyWombat
requested review from
SaschaSchwarze0 and
gabemontero
and removed request for
sbose78,
gabemontero and
SaschaSchwarze0
HeavyWombat
added
the
kind/failing-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
With the default implementation of
repo.List, the timeout seems to be rathershort and there are intermittent context deadline exceeded errors when running
the unit tests under load, or when repeating them over and over again.
Mitigate the error by switching to the list function that accepts a context. It
was added recently and privides the possibility to define a different timeout.
Refactor related code to make it more compact by removing superfluous returns.
In order to be able to test and reproduce it, I used Ginkgo with the
-untilItFailsand it started to be flaky after about 20 to 25 repetitions. With the code updates,
I was able to run it without issues for over 100 times, before canceling the test run.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes