Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ko and tested Kubernetes version #782

Merged
merged 1 commit into from
May 20, 2021
Merged

Update ko and tested Kubernetes version #782

merged 1 commit into from
May 20, 2021

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Two small dependency updates:

  1. Using ko v0.8.3 in the build strategy
  2. Using the newer 1.20.7 kind kubernetes image in integration and e2e tests

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Update sample build strategy to latest ko version

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label May 18, 2021
@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label May 18, 2021
HeavyWombat
HeavyWombat approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2021
qu1queee
qu1queee approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit c4a2f77 into shipwright-io:main May 20, 2021
@adambkaplan adambkaplan added this to the release-v0.5.0 milestone Jun 10, 2021
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-dependency-updates branch October 4, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@HeavyWombat HeavyWombat HeavyWombat approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@HeavyWombat HeavyWombat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note
Projects
None yet
Milestone
release-v0.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SaschaSchwarze0 @HeavyWombat @qu1queee @adambkaplan @openshift-merge-robot