Fix Git submodule update issue with SSH creds #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The credential look-up routine only set up the Git command line flags for the Git `clone` command, but not for the subsequent `submodule` command. When a user tried to use a repository with a submodule that required authentication as well, the Git step failed. Change code to store the respective credential command line arguments into a separate slice so that it can be used for different Git commands.
openshift-ci
bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The credential look-up routine only set up the Git command line flags for the
Git
clonecommand, but not for the subsequentsubmodulecommand. When auser tried to use a repository with a submodule that required authentication as
well, the Git step failed.
Change code to store the respective credential command line arguments into a
separate slice so that it can be used for different Git commands.
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes