Declutter Git step log output #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option flag to only show errors to keep the output brief.
There is a misleading message in the Git step that is cause by Tekton assuming to find a specific directory in the container image: ``` 2021/07/21 13:36:04 warning: unsuccessful cred copy: ".docker" from "/tekton/creds" to "/": unable to create destination directory: mkdir /.docker: permission denied ``` Add empty `.docker` directory with to avoid the warning.
When using the Git step with a SSH Git URL, a misleading message is returned in case the `git` command fails, e.g. wrong URL. ``` Could not create directory '/.ssh'. Failed to add the host to the list of known hosts (/.ssh/known_hosts). ERROR: Repository not found. fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. ``` Add empty `.ssh` directory to avoid the misleading message.
HeavyWombat
added
the
kind/cleanup
openshift-ci
bot
added
the
release-note
HeavyWombat
requested review from
SaschaSchwarze0
and removed request for
qu1queee
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We received end user feedback on some Git step output messages being misleading, which might take the focus away from the actual error message:
.dockerdirectory to base image to avoid warning..sshdirectory message by putting it into the base image.Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes