Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Source URL #107

Merged
merged 1 commit into from
Apr 4, 2022
Merged

Conversation

otaviof
Copy link
Member

@otaviof otaviof commented Apr 4, 2022

Changes

Making --source-url optional for shp build create.

Fixes #100

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

Making --source-url optional for `shp build create` subcommand.

-->

@otaviof otaviof added this to the release-v0.9.0 milestone Apr 4, 2022
@openshift-ci openshift-ci bot requested review from alicerum and sbose78 April 4, 2022 13:32
@otaviof
Copy link
Member Author

otaviof commented Apr 4, 2022

/assign @qu1queee @adambkaplan

@otaviof
Copy link
Member Author

otaviof commented Apr 4, 2022

/cc @SaschaSchwarze0 @HeavyWombat

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit b23c428 into shipwright-io:main Apr 4, 2022
@otaviof otaviof deleted the issue-100 branch April 4, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a LocalCopy Build
5 participants