Using ObjectMeta.CreationTimestamp as AGE column #116
Conversation
|
/assign @HeavyWombat |
pkg/shp/cmd/buildrun/list.go
Outdated
| age := "0s" | ||
| if br.Status.StartTime != nil { | ||
| age = duration.ShortHumanDuration(time.Since((br.Status.StartTime).Time)) | ||
| } |
There was a problem hiding this comment.
Given that we call it "age", should we maybe move to metadata.creationTimestamp which is always set?
There was a problem hiding this comment.
I think it makes sense, @SaschaSchwarze0. Given the idea is to report the BuildRun age, we can adopt the resource metadata.
However, the "start time" information is also relevant, how about we employ the metadata field to fix the issue at hand (#114), and create another issue for adding the "start time" as a new column?
/cc @HeavyWombat
There was a problem hiding this comment.
Sounds good. I think we can broaden the scope of the issue. We should generally check which columns we show in list calls and which data we show in get calls. I don't remember whether we thought about this in great detail initially. But since then we have some more data (like source details and output image digest) and we should revisit what we show.
There was a problem hiding this comment.
Thanks, good idea to extend the scope and add more columns, @SaschaSchwarze0, I've created #117 to capture.
And amended this PR to use the ObjectMeta.CreationTimestamp instead, please consider.
|
/retitle Using ObjectMeta.CreationTimestamp as AGE column |
openshift-ci
bot
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/assign @gabemontero @coreydaley |
Changes
Fixing #114 by checking if
.Status.StartTimeattribute isnil.Submitter Checklist
Includes docs if changes are user-facingRelease Notes