Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.20 and ko to v0.15.0 #161

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented Oct 27, 2023

Changes

Update build to use golang 1.20.x, and ko to v0.15.0 (latest release).

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Update golang to 1.20.x in our CI build and go.mod.
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2023
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Oct 27, 2023
@openshift-ci openshift-ci bot requested review from coreydaley and qu1queee October 27, 2023 16:07
Update ko to the latest release. This adds support for golang 1.20 and
1.21, plus brings in additional new features related to software supply
chain.
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2023
@adambkaplan adambkaplan changed the title WIP - Bump go to 1.20 Update go to 1.20 and ko to v0.15.0 Oct 27, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2023
@adambkaplan adambkaplan added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Oct 27, 2023
@jkhelil
Copy link
Contributor

jkhelil commented Oct 27, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
- Update go version references in development docs to v1.20 or higher
- Fix link to ko docs, now that they have an offical docs site.
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@openshift-ci openshift-ci bot merged commit 0e200fd into shipwright-io:main Oct 27, 2023
3 checks passed
@adambkaplan adambkaplan mentioned this pull request Oct 30, 2023
4 tasks
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Nov 2, 2023
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Feb 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants