Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Developer Guide #163

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

adambkaplan
Copy link
Member

Changes

This adds a developer guide that serves as an entrypoint for new code contributors. The operator project has existing documentation for local and OLM development, however it is buried in a nested directory that is not easy to find. Those documents also miss critical foundational knowledge, such as dev prerequisites and an understanding of OLM.

This PR also fixes the broken link to the contributor guidelines.

/kind documentation

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

This adds a developer guide that serves as an entrypoint for new code
contributors. The operator project has existing documentation for local
and OLM development, however it is buried in a nested directory that is
not easy to find. Those documents also miss critical foundational
knowledge, such as dev prerequisites and an understanding of OLM.

The new guide includes links to the Operator SDK and kubebuilder
tutorials, which will help contributors learn fundamentals like CRDs,
controllers, and packaging operators with OLM. I have also included
recommended tools when more than one choice is available in the market
(ex: docker or podman for a container engine). Finally, I have tried to
clarify when framework clis like `operator-sdk` and `kubebuilder` should
be used, and when it is safe to "just code."

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2023
@openshift-ci openshift-ci bot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 27, 2023
@openshift-ci openshift-ci bot requested review from HeavyWombat and jkhelil October 27, 2023 19:28
@jkhelil
Copy link
Contributor

jkhelil commented Oct 28, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2023
@qu1queee qu1queee requested review from qu1queee and removed request for HeavyWombat October 30, 2023 12:44
Copy link

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil, qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adambkaplan
Copy link
Member Author

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@adambkaplan: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Nov 2, 2023
@openshift-ci openshift-ci bot merged commit 5fe8cc0 into shipwright-io:main Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants