-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated go modules to 1.21 #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Giving the 👍 that we should update the golang version to 1.21. However, the CI GitHub action workflow also needs to be updated to use golang 1.21 (it currently uses 1.20)
In addition, @Adarsh-jaiss please ensure the pull request has a proper release note block, noting that we have updated the golang version to 1.21
@Adarsh-jaiss pls also help with the CI bump, see https://github.com/shipwright-io/operator/blob/main/.github/workflows/ci.yml#L21 |
Thank you so much @qu1queee for pointing it out. I have fixed it. Also I have a question, operator/.github/workflows/release.yaml Line 32 in e714be7
|
Yes |
Hey @SaschaSchwarze0 , I have made the significant changes, kindly review it once and please let me the further improvements to make if required :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Adarsh-jaiss, your changes all look good. May you have a look at the changes from the previous PR where the bump to 1.20 was done: https://github.com/shipwright-io/operator/pull/161/files
There are a few developer docs that also mention the Go version that are worth getting updates as well.
Thank you in advance.
Signed-off-by: adarsh-jaiss <its.adarshjaiss@gmail.com>
Thank you so much @SaschaSchwarze0 , I have done the changes and also updated the Ko version to v0.15.2 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Thank you.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes