Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated go modules to 1.21 #190

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

Adarsh-jaiss
Copy link
Member

@Adarsh-jaiss Adarsh-jaiss commented Feb 29, 2024

Changes

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 29, 2024
Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Giving the 👍 that we should update the golang version to 1.21. However, the CI GitHub action workflow also needs to be updated to use golang 1.21 (it currently uses 1.20)

In addition, @Adarsh-jaiss please ensure the pull request has a proper release note block, noting that we have updated the golang version to 1.21

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@qu1queee
Copy link

qu1queee commented Mar 5, 2024

@Adarsh-jaiss
Copy link
Member Author

Adarsh-jaiss commented Mar 5, 2024

Thank you so much @qu1queee for pointing it out. I have fixed it. Also I have a question,
Do we also need to update the release.yaml file?
Here:

go-version: 1.20.x

@SaschaSchwarze0
Copy link
Member

Thank you so much @qu1queee for pointing it out. I have fixed it. Also I have a question, Do we also need to update the release.yaml file? Here:

go-version: 1.20.x

Yes

@Adarsh-jaiss
Copy link
Member Author

Hey @SaschaSchwarze0 , I have made the significant changes, kindly review it once and please let me the further improvements to make if required :)

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adarsh-jaiss, your changes all look good. May you have a look at the changes from the previous PR where the bump to 1.20 was done: https://github.com/shipwright-io/operator/pull/161/files

There are a few developer docs that also mention the Go version that are worth getting updates as well.

Thank you in advance.

Signed-off-by: adarsh-jaiss <its.adarshjaiss@gmail.com>
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@Adarsh-jaiss
Copy link
Member Author

Thanks @Adarsh-jaiss, your changes all look good. May you have a look at the changes from the previous PR where the bump to 1.20 was done: https://github.com/shipwright-io/operator/pull/161/files

There are a few developer docs that also mention the Go version that are worth getting updates as well.

Thank you in advance.

Thank you so much @SaschaSchwarze0 , I have done the changes and also updated the Ko version to v0.15.2 :)
Please let me the know, if there are any other changes to make :)

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Thank you.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SaschaSchwarze0,adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a457e7b into shipwright-io:main Mar 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to Go 1.21
4 participants