Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tekton operator deps #234

Merged

Conversation

adambkaplan
Copy link
Member

@adambkaplan adambkaplan commented Dec 11, 2024

Changes

Update Tekton and k8s dependencies to most recent community supported versions, with related updates to code toolchains:

  1. Golang to v1.22
  2. k8s to 1.30.z
  3. Tekton Operator to v0.74.z

Prerequisite for #230

Fixes #178

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

action required: Minimum validated Tekton Operator version is v0.74.0; minimum validated Kubernetes version is v1.30.6. Other tooling such as Kustomize and controller-gen also updated to k8s 1.30 compatible versions.

@adambkaplan adambkaplan added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Dec 11, 2024
@openshift-ci openshift-ci bot requested review from jkhelil and otaviof December 11, 2024 20:16
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Dec 12, 2024
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@adambkaplan adambkaplan added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2024
- Update Tekton operator to v0.74.0, which brings install/upgrade
  support for Tekton Pipelines v0.62.z.
- Update sigs.k8s.io/controller-runtime to v0.18.6. This also updates
  k8s.io/* dependencies to v0.30.8

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
Updated `main.go` and the ShipwrightBuild controller test code to use
latest controller-runtime APIs (update included breaking changes).

Leaving the rest of the toolchain as is led to panics when generating
manifests with controller-gen. Therefore decided to update the
remaining tools to align with k8s 1.30.z:

- controller-gen to v0.15.0
- setup-envtest to release-0.18
- kustomize to v5.5.0 (most recent version)

This in turn required manifests to be regenerated. Operator-sdk was
left intact, as this does not appear to break with these updates.

Likewise updated Makefile and CI GitHub action to use golang 1.22 and
k8s 1.30, to ensure the version of k8s the operator tests with matches
the shipwright-io/build project version. Documentation for local and
OLM development updated to use latest versions of tools/operators -
notably updating Tekton Opertor to v0.74.0.

Signed-off-by: Adam Kaplan <adam.kaplan@redhat.com>
@adambkaplan adambkaplan force-pushed the update-tekton-operator-deps branch from 130ab7c to 1a078e6 Compare December 16, 2024 21:05
@adambkaplan
Copy link
Member Author

@SaschaSchwarze0 updated per your feedback - ptal

Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f903a7e into shipwright-io:main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update to Kustomize v5
2 participants