Setup php-build in separate docker layer #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glensc is this PR ready to merge? |
|
Looks like the build fails. Changed back to Draft |
The problem happens if the target path exists as a directory
|
Fixed with f538f6f. Ready for review/merge. |
|
@shivammathur please don't squash merge my PR's, it makes it very difficult to rebase and resolve conflicts, that's why I haven't been able to push out the changes I promised: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds separate layers for some steps allowing to cache and build in parallel.
This is a prelude of an idea to build other 5.x from source:
fpm and embed are built parallel: