Composer php version #639
Closed
Composer php version #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#629 |
|
@watarukura Thanks for the PR. I will have a look this weekend. |
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
===========================================
- Coverage 100.00% 97.65% -2.35%
===========================================
Files 6 6
Lines 538 555 +17
Branches 80 85 +5
===========================================
+ Hits 538 542 +4
- Misses 0 12 +12
- Partials 0 1 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Sorry, I'll retry, if I can understand this errors... |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: π Bug Fix, β Improvement or π New Feature
about: You found a bug, want to improve something or add a new feature
labels: bug or enhancement
A Pull Request should be associated with a Discussion.
close #629
Related discussion:
Description
This PR add args
version-file, and pick up PHP version from composer.json or .tool-versions or .php-version.npm run formatbefore the commit.npm run lintbefore the commit.npm run releasebefore the commit.npm testreturns with no unit test errors and all code covered.