Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify local dev setup, update CONTRIBUTING.md and recommend running scripts with node --run #1359

Merged
merged 2 commits into from
Oct 26, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Oct 26, 2024

This PR updates the contributing guide, which was a bit outdated, but also simplifies the local setup so that it requires less manual steps and is less coupled with the host environment.

@acelaya acelaya force-pushed the feature/improve-dev-setup branch 2 times, most recently from 65b1818 to 99b66be Compare October 26, 2024 11:15
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.11%. Comparing base (9094c1d) to head (2bbc3e6).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1359   +/-   ##
========================================
  Coverage    79.11%   79.11%           
========================================
  Files           49       49           
  Lines         1264     1264           
  Branches       242      242           
========================================
  Hits          1000     1000           
  Misses          23       23           
  Partials       241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 913264b into shlinkio:develop Oct 26, 2024
5 of 6 checks passed
@acelaya acelaya deleted the feature/improve-dev-setup branch October 26, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant