refactor: workaround tree shakable expression in ngrid/state

shlomiassaf · Jun 13, 2019 · abae5a5 · abae5a5
1 parent b195880
commit abae5a5
Show file tree

Hide file tree

Showing 12 changed files with 289 additions and 273 deletions.
diff --git a/libs/ngrid-material/package.json b/libs/ngrid-material/package.json
@@ -1,8 +1,8 @@
 {
   "name": "@pebula/ngrid-material",
-  "version": "1.0.0-alpha.21",
+  "version": "1.0.0-alpha.22",
   "peerDependencies": {
     "@angular/material": "^7.3.1",
-    "@pebula/ngrid": "1.0.0-alpha.21"
+    "@pebula/ngrid": "1.0.0-alpha.22"
   }
 }
diff --git a/libs/ngrid/package.json b/libs/ngrid/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pebula/ngrid",
-  "version": "1.0.0-alpha.21",
+  "version": "1.0.0-alpha.22",
   "peerDependencies": {
     "@angular/common": "^7.2.3",
     "@angular/core": "^7.2.3",

diff --git a/libs/ngrid/src/lib/ext/table-plugin.ts b/libs/ngrid/src/lib/ext/table-plugin.ts
@@ -9,9 +9,13 @@ export interface TablePluginMetadata<P extends keyof PblNgridPluginExtension = k
     ? PblNgridPluginExtensionFactories[P]
     : never
   ;
+  runOnce?: () => void;
 }
 
 export function TablePlugin(metadata: TablePluginMetadata) {
+  if (metadata.runOnce) {
+    metadata.runOnce();
+  }
   return target => {
     PLUGIN_STORE.set(metadata.id, { ...metadata, target });
   }

diff --git a/libs/ngrid/state/src/lib/core/built-in-handlers/_register.ts b/libs/ngrid/state/src/lib/core/built-in-handlers/_register.ts
@@ -0,0 +1,9 @@
+import { registerGridHandlers } from './grid-primitives/index';
+import { registerColumnOrderHandlers } from './column-order/index';
+import { registerColumnDefHandlers } from './column-def/index';
+
+export function registerBuiltInHandlers() {
+  registerGridHandlers();
+  registerColumnOrderHandlers();
+  registerColumnDefHandlers();
+}
diff --git a/libs/ngrid/state/src/lib/core/built-in-handlers/column-def/children.ts b/libs/ngrid/state/src/lib/core/built-in-handlers/column-def/children.ts
@@ -1,144 +1,146 @@
 import { PblColumnTypeDefinition } from '@pebula/ngrid';
 import { createStateChunkHandler } from '../../handling';
 
-/* ====================================================================================================================================================== */
-
-createStateChunkHandler('dataColumn')
-  .requiredKeys('id', 'prop')
-  .handleKeys(
-    'label', 'css', 'type', 'width', 'minWidth', 'maxWidth',              // PblNgridBaseColumnState (all optional)
-    'headerType', 'footerType', 'sort', 'sortAlias', 'editable', 'pin'    // All Optional
-  )
-  .serialize( (key, ctx) => {
-    const c = ctx.data.activeColumn || ctx.data.pblColumn;
-    if (c) {
+export function registerColumnDefChildHandlers() {
+  /* ====================================================================================================================================================== */
+
+  createStateChunkHandler('dataColumn')
+    .requiredKeys('id', 'prop')
+    .handleKeys(
+      'label', 'css', 'type', 'width', 'minWidth', 'maxWidth',              // PblNgridBaseColumnState (all optional)
+      'headerType', 'footerType', 'sort', 'sortAlias', 'editable', 'pin'    // All Optional
+    )
+    .serialize( (key, ctx) => {
+      const c = ctx.data.activeColumn || ctx.data.pblColumn;
+      if (c) {
+        switch (key) {
+          case 'prop':
+            return c.orgProp;
+          default:
+            break;
+        }
+      }
+
+      const value = c ? c[key] : ctx.source[key];
+
       switch (key) {
-        case 'prop':
-          return c.orgProp;
+        case 'sort':
+          if (typeof value === 'boolean') {
+            return value;
+          } else {
+            return;
+          }
         default:
           break;
       }
-    }
-
-    const value = c ? c[key] : ctx.source[key];
 
-    switch (key) {
-      case 'sort':
-        if (typeof value === 'boolean') {
-          return value;
-        } else {
-          return;
+      return value;
+    })
+    .deserialize( (key, stateValue, ctx) => {
+      const { activeColumn } = ctx.data;
+      if (activeColumn) {
+        switch (key) {
+          case 'width':
+            activeColumn.updateWidth(true, stateValue as any);
+            break;
         }
-      default:
-        break;
-    }
-
-    return value;
-  })
-  .deserialize( (key, stateValue, ctx) => {
-    const { activeColumn } = ctx.data;
-    if (activeColumn) {
-      switch (key) {
-        case 'width':
-          activeColumn.updateWidth(true, stateValue as any);
-          break;
       }
-    }
-    if (ctx.source) {
-      switch (key) {
-        case 'prop':
-          return;
-        case 'type':
-        case 'headerType':
-        case 'footerType':
-          const typeValue = ctx.source[key];
-          const stateTypeDef: PblColumnTypeDefinition = stateValue as any;
-          if (stateTypeDef && typeof stateTypeDef !== 'string' && typeValue && typeof typeValue !== 'string') {
-            typeValue.name = stateTypeDef.name;
-            if (stateTypeDef.data) {
-              typeValue.data = Object.assign(typeValue.data || {}, stateTypeDef.data);
-            }
+      if (ctx.source) {
+        switch (key) {
+          case 'prop':
             return;
-          }
-          break;
+          case 'type':
+          case 'headerType':
+          case 'footerType':
+            const typeValue = ctx.source[key];
+            const stateTypeDef: PblColumnTypeDefinition = stateValue as any;
+            if (stateTypeDef && typeof stateTypeDef !== 'string' && typeValue && typeof typeValue !== 'string') {
+              typeValue.name = stateTypeDef.name;
+              if (stateTypeDef.data) {
+                typeValue.data = Object.assign(typeValue.data || {}, stateTypeDef.data);
+              }
+              return;
+            }
+            break;
+        }
+        ctx.source[key] = stateValue;
+      }
+
+    })
+    .register();
+
+  /* ====================================================================================================================================================== */
+
+  createStateChunkHandler('dataMetaRow')
+    .handleKeys('rowClassName', 'type')    // All Optional
+    .serialize( (key, ctx) => {
+      const active = ctx.data.active || ctx.source;
+      if (active) {
+        return active[key];
       }
-      ctx.source[key] = stateValue;
-    }
-
-  })
-  .register();
-
-/* ====================================================================================================================================================== */
-
-createStateChunkHandler('dataMetaRow')
-  .handleKeys('rowClassName', 'type')    // All Optional
-  .serialize( (key, ctx) => {
-    const active = ctx.data.active || ctx.source;
-    if (active) {
-      return active[key];
-    }
-  })
-  .deserialize( (key, stateValue, ctx) => ctx.source[key] = stateValue )
-  .register();
-
-/* ====================================================================================================================================================== */
-
-createStateChunkHandler('metaRow')
-  // Note that we are not handling `cols`, this should be called from the parent, as a different child chunk handling process for each column
-  .handleKeys(
-    'rowClassName', 'type',    // All Optional like dataMetaRow
-    'rowIndex',                // Required
+    })
+    .deserialize( (key, stateValue, ctx) => ctx.source[key] = stateValue )
+    .register();
+
+  /* ====================================================================================================================================================== */
+
+  createStateChunkHandler('metaRow')
+    // Note that we are not handling `cols`, this should be called from the parent, as a different child chunk handling process for each column
+    .handleKeys(
+      'rowClassName', 'type',    // All Optional like dataMetaRow
+      'rowIndex',                // Required
+      )
+    .serialize( (key, ctx) => {
+      return ctx.source[key];
+    })
+    .deserialize( (key, stateValue, ctx) => {
+
+    })
+    .register();
+
+  /* ====================================================================================================================================================== */
+
+  createStateChunkHandler('metaGroupRow')
+    // Note that we are not handling `cols`, this should be called from the parent, as a different child chunk handling process for each column
+    .handleKeys(
+      'rowClassName', 'type',    // All Optional like dataMetaRow
+      'rowIndex',                // Required
+      )
+    .serialize( (key, ctx) => {
+      return ctx.source[key];
+    })
+    .deserialize( (key, stateValue, ctx) => {
+
+    })
+    .register();
+
+  /* ====================================================================================================================================================== */
+
+  createStateChunkHandler('metaColumn')
+    .requiredKeys('kind', 'rowIndex')
+    .handleKeys(
+      'id', 'label', 'css', 'type', 'width', 'minWidth', 'maxWidth',        // PblNgridBaseColumnState (all optional)
     )
-  .serialize( (key, ctx) => {
-    return ctx.source[key];
-  })
-  .deserialize( (key, stateValue, ctx) => {
+    .serialize( (key, ctx) => {
+      return ctx.source[key];
+    })
+    .deserialize( (key, stateValue, ctx) => {
 
-  })
-  .register();
+    })
+    .register();
 
-/* ====================================================================================================================================================== */
+  /* ====================================================================================================================================================== */
 
-createStateChunkHandler('metaGroupRow')
-  // Note that we are not handling `cols`, this should be called from the parent, as a different child chunk handling process for each column
-  .handleKeys(
-    'rowClassName', 'type',    // All Optional like dataMetaRow
-    'rowIndex',                // Required
+  createStateChunkHandler('metaGroupColumn')
+    .requiredKeys('prop', 'rowIndex', 'span')
+    .handleKeys(
+      'id', 'label', 'css', 'type', 'width', 'minWidth', 'maxWidth',        // PblNgridBaseColumnState (all optional)
     )
-  .serialize( (key, ctx) => {
-    return ctx.source[key];
-  })
-  .deserialize( (key, stateValue, ctx) => {
-
-  })
-  .register();
-
-/* ====================================================================================================================================================== */
-
-createStateChunkHandler('metaColumn')
-  .requiredKeys('kind', 'rowIndex')
-  .handleKeys(
-    'id', 'label', 'css', 'type', 'width', 'minWidth', 'maxWidth',        // PblNgridBaseColumnState (all optional)
-  )
-  .serialize( (key, ctx) => {
-    return ctx.source[key];
-  })
-  .deserialize( (key, stateValue, ctx) => {
-
-  })
-  .register();
-
-/* ====================================================================================================================================================== */
-
-createStateChunkHandler('metaGroupColumn')
-  .requiredKeys('prop', 'rowIndex', 'span')
-  .handleKeys(
-    'id', 'label', 'css', 'type', 'width', 'minWidth', 'maxWidth',        // PblNgridBaseColumnState (all optional)
-  )
-  .serialize( (key, ctx) => {
-    return ctx.source[key];
-  })
-  .deserialize( (key, stateValue, ctx) => {
-
-  })
-  .register();
+    .serialize( (key, ctx) => {
+      return ctx.source[key];
+    })
+    .deserialize( (key, stateValue, ctx) => {
+
+    })
+    .register();
+}