support: all or nothing #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sho-hata
force-pushed
the
feature/all_or_nothing
branch
from
67775d2 to
b0ebb7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
runmethod in thetparagen.gofile, focusing on improving error handling and ensuring temporary files are managed correctly.Error handling improvements and temporary file management:
deferfunction to ensure all temporary files are removed at the end of therunmethod, regardless of whether an error occurs. (tparagen.go, tparagen.goL59-R74)tempFiles.Storecall to only store the temporary file path if writing to the file is successful. (tparagen.go, tparagen.goL93-R115)walker.Walkif it occurs, instead of manually removing temporary files in the error case. (tparagen.go, tparagen.goL93-R115)