Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Android - Pass audioSettings.muted to RtmpStream #21

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

brauliolomeli
Copy link
Contributor

Description & motivation

Allows muting a stream on Android by calling: stream.audioSettings = AudioSettings(muted: true)

Related discussion: #20

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

- This allows to mute a stream on Android by calling:
`stream.audioSettings = AudioSettings(muted: true)`
Copy link
Owner

@shogo4405 shogo4405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@shogo4405 shogo4405 added this to the 0.9.4 milestone Jan 28, 2023
@shogo4405 shogo4405 merged commit 53c4d0e into shogo4405:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants