Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setAudioSettings were used instead of setVideoSettings #7

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

Kodam-zz
Copy link
Contributor

@Kodam-zz Kodam-zz commented Oct 6, 2022

Description & motivation

setAudioSettings were used in set videoSettings and set captureSettings, so all videoSettings changes were ignored.

  set videoSettings(VideoSettings videoSettings) {
    assert(_memory != null);
    _videoSettings = videoSettings;
    RtmpStreamPlatform.instance.setAudioSettings( // <- this should to be RtmpStreamPlatform.instance.setVideoSettings(
        {"memory": _memory, "settings": videoSettings.toMap()});
  }

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@shogo4405
Copy link
Owner

Thanks so much!!

@shogo4405 shogo4405 merged commit 489a8c3 into shogo4405:main Oct 6, 2022
@TheFe91 TheFe91 mentioned this pull request Nov 17, 2022
@shogo4405 shogo4405 added this to the 0.9.2 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants