Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled a11y in the filter feature #837

Merged
merged 22 commits into from
Oct 2, 2019
Merged

Enabled a11y in the filter feature #837

merged 22 commits into from
Oct 2, 2019

Conversation

devbucket
Copy link
Contributor

Description

In order to make the filter feature accessible, we optimised it and added a11y features.

Type of change

Please add an "x" into the option that is relevant:

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@devbucket devbucket added the enhancement New feature or request label Sep 24, 2019
@devbucket devbucket self-assigned this Sep 24, 2019
fkloes
fkloes requested changes Sep 26, 2019
View reviewed changes
libraries/ui-material/Accordion/index.jsx Outdated Show resolved Hide resolved
themes/theme-gmd/locale/de-DE.json Show resolved Hide resolved
themes/theme-gmd/pages/Filter/components/Content/components/ApplyButton/index.jsx Outdated Show resolved Hide resolved
themes/theme-gmd/pages/Filter/components/Content/components/ResetButton/index.jsx Outdated Show resolved Hide resolved
themes/theme-gmd/pages/Filter/components/Content/components/Selector/index.jsx Show resolved Hide resolved
themes/theme-ios11/pages/Filter/components/Content/components/ResetButton/index.jsx Show resolved Hide resolved
themes/theme-ios11/pages/Filter/components/Content/components/Selector/index.jsx Show resolved Hide resolved
libraries/engage/components/RangeSlider/index.jsx Outdated Show resolved Hide resolved
fkloes
fkloes previously requested changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@fkloes fkloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • price range inputs can't be focused. instead accordions nearby are toggled
  • apply buttons are still hidden from the screen reader when disabled (iOS and GMD)
  • unit tests are failing

@devbucket
Copy link
Contributor Author

  • Apply filter buttons are now visible again
  • The failing unit tests skipped for now.

@alexbridge alexbridge dismissed fkloes’s stale review October 2, 2019 09:14

All is checked

@alexbridge alexbridge merged commit b1413f4 into v6.9.0 Oct 2, 2019
@alexbridge alexbridge deleted the PWA-2159-a11y-filter-button branch October 2, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbridge alexbridge alexbridge approved these changes

@fkloes fkloes fkloes left review comments

Assignees

@devbucket devbucket

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devbucket @fkloes @alexbridge