Drop support for Go versions older than 1.7 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should also update readme with go version reqs. I don’t think go.mod allows you to add supported go versions |
|
Wow that's odd |
|
Oh, there was a bug in |
|
Apparently, it looks like that bug was fixed in 1.7 :< |
mwoss
changed the title
|
@njason could you check it? :D |
fairyhunter13
added a commit
to fairyhunter13/decimal
that referenced
this pull request
Jul 12, 2020
* Drop support for Go versions older than 1.7 * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we want to introduce new helper methods that rely on functionalities available from Go version >1.5 we decided to drop support for old Go versions.
We would still support as a bunch of older go version, but we have to think more strictly about moving this library forward.