Skip to content

Commit

Permalink
[framework] exclude main variant from selling when it has no selling …
Browse files Browse the repository at this point in the history 
…or visible variants (#3303)
  • Loading branch information
@malyMiso
malyMiso committed Aug 8, 2024
2 parents 0163281 + 3db2116 commit a8d56a6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 268 deletions.
267 changes: 0 additions & 267 deletions app/src/Model/Product/ProductSellingDeniedRecalculator.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,275 +4,8 @@

namespace App\Model\Product;

use Doctrine\DBAL\ArrayParameterType;
use Doctrine\DBAL\Types\Types;
use Doctrine\ORM\EntityManagerInterface;
use Shopsys\FrameworkBundle\Component\Domain\Domain;
use Shopsys\FrameworkBundle\Model\Product\Product;
use Shopsys\FrameworkBundle\Model\Product\ProductSellingDeniedRecalculator as BaseProductSellingDeniedRecalculator;

class ProductSellingDeniedRecalculator extends BaseProductSellingDeniedRecalculator
{
/**
* @param \Doctrine\ORM\EntityManagerInterface $entityManager
* @param \Shopsys\FrameworkBundle\Component\Domain\Domain $domain
*/
public function __construct(
EntityManagerInterface $entityManager,
private readonly Domain $domain,
) {
parent::__construct($entityManager);
}

/**
* {@inheritdoc}
*/
protected function calculate(array $productIds = []): void
{
$this->calculateIndependent($productIds);
$this->propagateCalculatedSaleExclusionToCalculatedSellingDenied($productIds);
$this->propagateMainVariantSellingDeniedToVariants($productIds);
$this->propagateVariantsSellingDeniedToMainVariant($productIds);
}

/**
* {@inheritdoc}
*/
protected function calculateIndependent(array $productIds): void
{
$qb = $this->em->createQueryBuilder()
->update(Product::class, 'p')
->set('p.calculatedSellingDenied', 'p.sellingDenied');

if (count($productIds) > 0) {
$qb->andWhere('p IN (:productIds)')->setParameter('productIds', $productIds);
}
$qb->getQuery()->execute();

$this->calculatePerDomain($productIds);
}

/**
* @param int[] $productIds
*/
private function calculatePerDomain(array $productIds): void
{
$query = 'UPDATE product_domains AS pd
SET calculated_sale_exclusion = CASE
WHEN (
p.calculated_selling_denied = TRUE
OR
pd.domain_hidden = TRUE
OR (
p.variant_type != :variantTypeMain
AND
NOT EXISTS(
SELECT 1
FROM product_stocks as ps
JOIN stocks as s ON s.id = ps.stock_id
JOIN stock_domains sd ON s.id = sd.stock_id AND sd.domain_id = :domainId
WHERE ps.product_id = p.id AND sd.is_enabled = TRUE
HAVING SUM(ps.product_quantity) > 0
)
)
OR (
pd.sale_exclusion = TRUE
AND
p.variant_type = :variantTypeMain
)
)
THEN TRUE
ELSE FALSE
END
FROM products AS p
WHERE p.id = pd.product_id
AND pd.domain_id = :domainId
' . (count($productIds) > 0 ? ' AND p.id IN (:productIds)' : '');

$params = [];
$params['productIds'] = $productIds;
$params['variantTypeMain'] = Product::VARIANT_TYPE_MAIN;

foreach ($this->domain->getAll() as $domain) {
$params['domainId'] = $domain->getId();

$this->em->getConnection()->executeStatement(
$query,
$params,
[
'productIds' => ArrayParameterType::INTEGER,
'variantTypeMain' => Types::STRING,
'domainId' => Types::INTEGER,
],
);
}
}

/**
* @param int[] $productIds
*/
private function propagateCalculatedSaleExclusionToCalculatedSellingDenied(array $productIds): void
{
$query = 'UPDATE products as p
SET calculated_selling_denied = TRUE
WHERE p.calculated_selling_denied = FALSE
AND NOT EXISTS (
SELECT 1
FROM product_domains as pd
WHERE pd.product_id = p.id
AND pd.calculated_sale_exclusion = FALSE
)
' . (count($productIds) > 0 ? ' AND p.id IN (:productIds)' : '');

$this->em->getConnection()->executeStatement(
$query,
['productIds' => $productIds],
['productIds' => ArrayParameterType::INTEGER],
);
}

/**
* @param int[] $productIds
*/
protected function propagateMainVariantSellingDeniedToVariants(array $productIds): void
{
parent::propagateMainVariantSellingDeniedToVariants($productIds);

$this->propagateMainVariantSellingDeniedToVariantsCalculatedSaleExclusion($productIds);
$this->propagateMainVariantCalculateSaleExclusionToVariantsCalculatedSaleExclusion($productIds);
}

/**
* @param int[] $productIds
*/
private function propagateMainVariantSellingDeniedToVariantsCalculatedSaleExclusion(array $productIds): void
{
$query = 'UPDATE product_domains as pd
SET calculated_sale_exclusion = TRUE
FROM products as p
JOIN products as m ON p.main_variant_id = m.id
WHERE m.variant_type = :variantTypeMain
AND pd.product_id = p.id
AND pd.calculated_sale_exclusion = FALSE
AND p.calculated_selling_denied = TRUE
' . (count($productIds) > 0 ? ' AND m.id IN (:productIds)' : '');

$this->em->getConnection()->executeStatement(
$query,
[
'productIds' => $productIds,
'variantTypeMain' => Product::VARIANT_TYPE_MAIN,
],
[
'productIds' => ArrayParameterType::INTEGER,
'variantTypeMain' => Types::STRING,
],
);
}

/**
* @param int[] $productIds
*/
private function propagateMainVariantCalculateSaleExclusionToVariantsCalculatedSaleExclusion(
array $productIds,
): void {
$query = 'UPDATE product_domains as pd
SET calculated_sale_exclusion = TRUE
FROM products as p
JOIN products as m ON p.main_variant_id = m.id
JOIN product_domains as pdm ON pdm.product_id = m.id
WHERE m.variant_type = :variantTypeMain
AND pd.product_id = p.id
AND pdm.domain_id = pd.domain_id
AND pd.calculated_sale_exclusion = FALSE
AND pdm.calculated_sale_exclusion = TRUE
' . (count($productIds) > 0 ? ' AND m.id IN (:productIds)' : '');

$this->em->getConnection()->executeStatement(
$query,
[
'productIds' => $productIds,
'variantTypeMain' => Product::VARIANT_TYPE_MAIN,
],
[
'productIds' => ArrayParameterType::INTEGER,
'variantTypeMain' => Types::STRING,
],
);
}

/**
* @param int[] $productIds
*/
protected function propagateVariantsSellingDeniedToMainVariant(array $productIds): void
{
parent::propagateVariantsSellingDeniedToMainVariant($productIds);

$this->propagateVariantsSaleExclusionToMainVariantCalculateSaleExclusion($productIds);
$this->propagateVariantsSaleExclusionToMainVariantCalculateSellingDenied($productIds);
}

/**
* @param int[] $productIds
*/
private function propagateVariantsSaleExclusionToMainVariantCalculateSaleExclusion(array $productIds): void
{
$query = 'UPDATE product_domains as pd
SET calculated_sale_exclusion = TRUE
FROM products as p
WHERE p.variant_type = :variantTypeMain
AND pd.product_id = p.id
AND pd.calculated_sale_exclusion = FALSE
AND NOT EXISTS (
SELECT 1
FROM products as v
JOIN product_domains as pdv ON pdv.product_id = v.id AND pdv.domain_id = pd.domain_id
WHERE v.main_variant_id = p.id
AND pdv.calculated_sale_exclusion = FALSE
)
' . (count($productIds) > 0 ? ' AND p.id IN (:productIds)' : '');

$this->em->getConnection()->executeStatement(
$query,
[
'productIds' => $productIds,
'variantTypeMain' => Product::VARIANT_TYPE_MAIN,
],
[
'productIds' => ArrayParameterType::INTEGER,
'variantTypeMain' => Types::STRING,
],
);
}

/**
* @param int[] $productIds
*/
private function propagateVariantsSaleExclusionToMainVariantCalculateSellingDenied(array $productIds): void
{
$query = 'UPDATE products as p
SET calculated_selling_denied = TRUE
WHERE p.variant_type = :variantTypeMain
AND p.calculated_selling_denied = FALSE
AND NOT EXISTS (
SELECT 1
FROM products as v
JOIN product_domains as pdv ON pdv.product_id = v.id
WHERE v.main_variant_id = p.id
AND pdv.calculated_sale_exclusion = FALSE
)
' . (count($productIds) > 0 ? ' AND p.id IN (:productIds)' : '');

$this->em->getConnection()->executeStatement(
$query,
[
'productIds' => $productIds,
'variantTypeMain' => Product::VARIANT_TYPE_MAIN,
],
[
'productIds' => ArrayParameterType::INTEGER,
'variantTypeMain' => Types::STRING,
],
);
}
}
2 changes: 1 addition & 1 deletion storefront/components/Blocks/Product/ProductsList/ProductListItem.tsx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ export const ProductListItem = forwardRef<HTMLLIElement, ProductItemProps>(
</div>

<div>
{visibleItemsConfig.price && (
{visibleItemsConfig.price && product.isMainVariant && !product.isSellingDenied && (
<ProductPrice
isPriceFromVisible={visibleItemsConfig.priceFromWord}
productPrice={product.price}
Expand Down

0 comments on commit a8d56a6

Please sign in to comment.