[shopsys] stop using excluded_404s in monolog config for incompatible types #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the excluded_404s config works only for fingers_crossed type - the config should be unset when the type is changed - this makes the configuration compatible with symfony/monolog-bundle in v3.4.0
vitek-rostislav
approved these changes
Jun 24, 2019
|
tested, everything works! 🎉 👌 |
LukasHeinz
suggested changes
Jun 24, 2019
LukasHeinz
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/monolog-bundlethrows an error when usingexcluded_404sorexcluded_http_codesconfiguration in types other thanfingers_crossedsincev3.4.0, as explained in symfony/monolog-bundle#309 - this PR fixes the configuration on our side. Also, reverts #1148 as it fixes the incompatibility.