Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-base] PhpStan level lowered to 1 in project-base #1199

Merged
merged 3 commits into from
Jul 15, 2019
Merged

[project-base] PhpStan level lowered to 1 in project-base #1199

merged 3 commits into from
Jul 15, 2019

Conversation

grossmannmartin
Copy link
Member

Q A
Description, reason for the PR PHPStan on level 4 does not comply with framework extensibility options. Level 1 is recommended on a project level. (Level 4 is still used in framework).
New feature No
BC breaks No
Fixes issues ...
Have you read and signed our License Agreement for contributions? Yes

simara-svatopluk
simara-svatopluk previously requested changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@simara-svatopluk simara-svatopluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you removed couple of instructions, but I guess they were for levels 2-4... I see that type checking is in lvl 2, so seems good

docs/upgrade/UPGRADE-v7.3.0.md Show resolved Hide resolved
docs/upgrade/phpstan-level-1.md Show resolved Hide resolved
docs/upgrade/phpstan-level-1.md Outdated Show resolved Hide resolved
docs/upgrade/phpstan-level-1.md Outdated Show resolved Hide resolved
docs/upgrade/phpstan-level-1.md Outdated Show resolved Hide resolved
@grossmannmartin grossmannmartin mentioned this pull request Jul 11, 2019
Merged
@grossmannmartin
All properties are now defined before import main Phing build file
a92391f 
- properties are not overwritten, but first defined is used
@grossmannmartin grossmannmartin force-pushed the mg-lower-project-base-phpstan-lvl branch from 7f505f8 to e74e0cb Compare July 15, 2019 07:28
vitek-rostislav
vitek-rostislav approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@vitek-rostislav vitek-rostislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/upgrade/phpstan-level-1.md Outdated Show resolved Hide resolved
@simara-svatopluk simara-svatopluk dismissed their stale review July 15, 2019 09:10

Rostislav have taken the review

@grossmannmartin grossmannmartin force-pushed the mg-lower-project-base-phpstan-lvl branch 3 times, most recently from 5cb41af to 615247b Compare July 15, 2019 11:57
@grossmannmartin grossmannmartin force-pushed the mg-lower-project-base-phpstan-lvl branch from 615247b to 9d26f04 Compare July 15, 2019 12:15
@grossmannmartin grossmannmartin merged commit 3b88c6d into 7.3 Jul 15, 2019
@grossmannmartin grossmannmartin deleted the mg-lower-project-base-phpstan-lvl branch July 15, 2019 12:31
@grossmannmartin grossmannmartin mentioned this pull request Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHeinz LukasHeinz LukasHeinz left review comments

@vitek-rostislav vitek-rostislav vitek-rostislav approved these changes

@simara-svatopluk simara-svatopluk simara-svatopluk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grossmannmartin @simara-svatopluk @vitek-rostislav @LukasHeinz