Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[project-base] be more descriptive about UnableToResolveDomainResponse #701

Merged
merged 2 commits into from
May 3, 2019
Merged

[project-base] be more descriptive about UnableToResolveDomainResponse #701

merged 2 commits into from
May 3, 2019

Conversation

MattCzerner
Copy link
Contributor

@MattCzerner MattCzerner commented Dec 21, 2018 •
edited
Loading

error now tells you about active TEST environment which overwrites
domain url

Q A
Description, reason for the PR Having active TEST environment is not obvious when having UnableToResolveDomainResponse
New feature No
BC breaks No
Fixes issues
Standards and tests pass Yes
Have you read and signed our License Agreement for contributions? Yes

@MattCzerner MattCzerner changed the title Be more descriptive about UnableToResolveDomainResponse [project-base] be more descriptive about UnableToResolveDomainResponse Dec 21, 2018
@MattCzerner MattCzerner force-pushed the mc-error-test-url branch 2 times, most recently from 740ccd3 to a22d8c5 Compare January 29, 2019 14:54
@boris-brtan
Copy link
Contributor

hi, was here some progress?

@MattCzerner
Copy link
Contributor Author

Rebased, fixed @TomasLudvik.

Mathew Czerner added 2 commits May 2, 2019 15:23
@grossmannmartin
be more descriptive about UnableToResolverDomainResponse
f885ebf 
- error now tells you about active TEST environment which overwrites
domain url
@grossmannmartin
added record to UPGRADE.md file
48be0f4
@grossmannmartin
Copy link
Member

grossmannmartin commented May 2, 2019 •
edited
Loading

Hi, I rebased to current master and test this PR. Everything seems ok and I like the idea, so I think it can be validated 👍

Also I don't think this is a BC Break, if you agree, update the description please.

@MattCzerner MattCzerner merged commit 74f462b into master May 3, 2019
@MattCzerner MattCzerner deleted the mc-error-test-url branch May 3, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasLudvik TomasLudvik TomasLudvik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MattCzerner @boris-brtan @grossmannmartin @TomasLudvik