[shopsys] add checker to check availability of redis #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DavidOstrozlik
commented
Feb 11, 2019
•
DavidOstrozlik
commented
| Q | A |
|---|---|
| Description, reason for the PR | we don't have any way that would alert developer that Redis is not running while building the application or running phing commands |
| New feature | Yes |
| BC breaks | Yes |
| Fixes issues | closes #744 |
| Standards and tests pass | Yes |
| Have you read and signed our License Agreement for contributions? | Yes |
DavidOstrozlik
force-pushed
the
do-redis-check
branch
2 times, most recently
from
4e2d24e
to
01522db
Compare
TomasLudvik
requested changes
Feb 12, 2019
docs/upgrade/UPGRADE-unreleased.md
Outdated
| - RUN pecl install redis-4.0.2 && \ | ||
| + RUN pecl install redis-4.1.1 && \ | ||
| ``` | ||
| - add a new phing target `redis-check` to your `build-dev.xml` and use it where you need to check if Redis is running |
There was a problem hiding this comment.
Suggested change
| - add a new phing target `redis-check` to your `build-dev.xml` and use it where you need to check if Redis is running | |
| - add a new phing target `redis-check` to your `build-dev.xml` and use it before any call to Redis like `redis-check` |
There was a problem hiding this comment.
I changed the message
DavidOstrozlik
force-pushed
the
do-redis-check
branch
2 times, most recently
from
79a6f02
to
289bedb
Compare
TomasLudvik
requested changes
Feb 12, 2019
TomasLudvik
approved these changes
Feb 12, 2019
DavidOstrozlik
commented
Feb 13, 2019
docs/upgrade/UPGRADE-unreleased.md
Outdated
| @@ -31,6 +31,21 @@ for instance: | |||
| - *(optional)* add a new [script](https://github.com/shopsys/shopsys/pull/759/files#diff-e5f46a7c45e95214037078344ce17721) to `scripts/install.sh` | |||
| - this script serves as a fast way to install demo instance of Shopsys Framework. | |||
| - also this script can be used if you change the configuration of docker or app, script will apply all the changes done in these files and rebuild images. | |||
| - upgrade redis extension version in your `DockerFile` to version `4.1.1` | |||
There was a problem hiding this comment.
add PR headline
DavidOstrozlik
force-pushed
the
do-redis-check
branch
from
3467729
to
d272b4a
Compare
…upports lazy loading - upgraded redis-bundle to version 2.1.8 - upgraded redis extension to version 4.1.1 - added proxy-manager-bridge with version ^3.4
DavidOstrozlik
force-pushed
the
do-redis-check
branch
from
d272b4a
to
f36de69
Compare
This was referenced Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.