Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update customer language on login #2664

Closed
wants to merge 2 commits into from
Closed

Update customer language on login #2664

wants to merge 2 commits into from

Conversation

alessandroaussems
Copy link
Contributor

@alessandroaussems alessandroaussems commented Aug 22, 2022

1. Why is this change necessary?

Fixes: https://issues.shopware.com/issues/NEXT-22927

2. What does this change do, exactly?

Update languageId from customer to the active language from the shop on login

3. Describe each step to reproduce the issue or behaviour.

See: https://issues.shopware.com/issues/NEXT-22927

4. Please link to the relevant issues (if any).

https://issues.shopware.com/issues/NEXT-22927

5. Checklist

  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #2664 (9d696fd) into trunk (07310a7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            trunk    #2664      +/-   ##
==========================================
+ Coverage   64.65%   64.67%   +0.01%     
==========================================
  Files        3599     3599              
  Lines       80273    80284      +11     
==========================================
+ Hits        51899    51920      +21     
+ Misses      28374    28364      -10     
Impacted Files Coverage Δ
...Core/Checkout/Customer/SalesChannel/LoginRoute.php 89.06% <100.00%> (+0.17%) ⬆️
...Framework/Rule/Container/MatchAllLineItemsRule.php 70.96% <0.00%> (-3.23%) ⬇️
.../Api/ApiDefinition/Generator/OpenApi3Generator.php 61.90% <0.00%> (-1.91%) ⬇️
...c/Core/Content/Sitemap/Service/SitemapExporter.php 92.06% <0.00%> (-1.59%) ⬇️
...ent/MailTemplate/Subscriber/MailSendSubscriber.php 78.86% <0.00%> (-0.82%) ⬇️
src/Core/Installer/Installer.php 100.00% <0.00%> (ø)
...tionLayer/CheapestPrice/CheapestPriceContainer.php 89.24% <0.00%> (+0.74%) ⬆️
...Flow/Dispatching/Action/GenerateDocumentAction.php 80.00% <0.00%> (+1.25%) ⬆️
...ataAbstractionLayer/DefinitionInstanceRegistry.php 91.37% <0.00%> (+1.72%) ⬆️
...Core/Checkout/Cart/Delivery/DeliveryCalculator.php 96.15% <0.00%> (+1.92%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@keulinho keulinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 💙

Can you add a testcase for your fix?

@shopwareBot
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-22959

Please use this issue to track the state of your pull request.

@NiklasLimberg
Copy link
Contributor

Thanks for your contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants