Check if resource after filesystem::putStream still exists, before closing #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinect
force-pushed
the
checkIfResourceOfPutStreamExists
branch
from
68a12a2
to
93363f5
Compare
|
Hello, thank you for creating this pull request. Please use this issue to track the state of your pull request. |
|
Hey @tinect, thanks for your contribution 💙 |
shopwareBot
pushed a commit
to shopware/core
that referenced
this pull request
Aug 7, 2020
…ts, before closing fixes shopware/shopware#1224 fixes shopware/shopware#1223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
See #1223
2. What does this change do, exactly?
Add checks after each putStream.
3. Describe each step to reproduce the issue or behaviour.
See #1223
4. Please link to the relevant issues (if any).
5. Checklist