-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEXT-37536 - Added column conversion via column_type mapping option #39
NEXT-37536 - Added column conversion via column_type mapping option #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💪 , just added some suggestions 🙂
4320c7c
to
fce3573
Compare
6a42d0c
to
65d39b4
Compare
65d39b4
to
6e9b852
Compare
Summary of the total line code coverage for the whole codebase
Summary of each file (click to expand)
More details (click to expand)Download full HTML reportYou can download the full HTML report here: click to download You can also generate these reports locallyFor that, you need to install cargo-llvm-cov, then you can run: cargo llvm-cov --all-features --no-fail-fast --open Hint: There are also other ways to see code coverage in Rust. For example with RustRover, you can execute tests with coverage generation directly in the IDE. RememberYour tests should be meaningful and not just be written to raise the coverage. |
Description
When inferring the type of a value from the target file during an import the error that the API needs some other type occurred.
E.g.:
The product number 42 was converted to a number value, but the API expected a string.
Solution
I've added the mapping option
column_type
with which the user can specify the type of every cell in the column.Valid options currently are
string
,boolean
andnumber
.The issue mentioned could for example be solved like this:
The only tripwire is that the user could specify a wrong type, e.g. adds the
number
type on the active field (boolean) of the product which will obviously fail whilst importing.The import for that specific chunk will be aborted with an error message similar to this:
The export will be unaffected.