Skip to content

Commit

Permalink
Merge pull request #13 from emmer91/ntr/master/change-dbal-requiremen…
Browse files Browse the repository at this point in the history 
…t-to-dev

NTR - set dbal requirement to dev
  • Loading branch information
@teiling88
teiling88 authored Jun 15, 2018
2 parents e63f5c8 + 78475e7 commit 5c97237
Show file tree
Hide file tree
Showing 2 changed files with 208 additions and 201 deletions.
6 changes: 3 additions & 3 deletions composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
}
},
"require": {
"php": "^7.0",
"doctrine/dbal": "^2.5"
"php": "^7.0"
},
"require-dev": {
"phpunit/phpunit": "^6.2"
"phpunit/phpunit": "^6.2",
"doctrine/dbal": "^2.5"
},
"license": "MIT",
"authors": [
Expand Down
Loading

2 comments on commit 5c97237

@bcremer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? doctrine/dbal is a direct dependency in your src/ directory, hence it should be declared in the require section.

@teiling88
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jep that it is correct but if you create the B2B Package you will add the not Shopware fixed DBAL/Doctrine Version to Shopware and you know what then happens :-)

It is for the moment a quick fix to release the B2B Suite 2.0.

Please sign in to comment.