Skip to content

Commit

Permalink
Merge pull request #2812 from shopware5/chore/update-phpstan
Browse files Browse the repository at this point in the history
chore: Update PHPStan
  • Loading branch information
mitelg authored Nov 14, 2024
2 parents 3515596 + cd34d77 commit 4f305a5
Show file tree
Hide file tree
Showing 15 changed files with 208 additions and 323 deletions.
94 changes: 2 additions & 92 deletions .phpstan-baseline.neon
Original file line number Diff line number Diff line change
Expand Up @@ -3220,11 +3220,6 @@ parameters:
count: 1
path: engine/Library/Enlight/Template/Plugins/block.stripLines.php

-
message: "#^Function smarty_block_stripLines\\(\\) never returns void so it can be removed from the return type\\.$#"
count: 1
path: engine/Library/Enlight/Template/Plugins/block.stripLines.php

-
message: "#^Method Smarty_Compiler_Config\\:\\:compile\\(\\) has parameter \\$args with no value type specified in iterable type array\\.$#"
count: 1
Expand Down Expand Up @@ -11855,36 +11850,6 @@ parameters:
count: 1
path: engine/Shopware/Commands/DatabaseSetupCommand.php

-
message: "#^Method Shopware\\\\Commands\\\\FirstRunWizardDisableCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: engine/Shopware/Commands/FirstRunWizardDisableCommand.php

-
message: "#^Query error\\: Column \"s_core_config_values\\.element_id\" expects value type int, got type mixed$#"
count: 2
path: engine/Shopware/Commands/FirstRunWizardDisableCommand.php

-
message: "#^Query error\\: Column \"s_core_config_values\\.id\" expects value type int, got type mixed~0\\|0\\.0\\|''\\|'0'\\|array\\{\\}\\|false\\|null$#"
count: 1
path: engine/Shopware/Commands/FirstRunWizardDisableCommand.php

-
message: "#^Method Shopware\\\\Commands\\\\FirstRunWizardEnableCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
path: engine/Shopware/Commands/FirstRunWizardEnableCommand.php

-
message: "#^Query error\\: Column \"s_core_config_values\\.element_id\" expects value type int, got type mixed$#"
count: 2
path: engine/Shopware/Commands/FirstRunWizardEnableCommand.php

-
message: "#^Query error\\: Column \"s_core_config_values\\.id\" expects value type int, got type mixed~0\\|0\\.0\\|''\\|'0'\\|array\\{\\}\\|false\\|null$#"
count: 1
path: engine/Shopware/Commands/FirstRunWizardEnableCommand.php

-
message: "#^Method Shopware\\\\Commands\\\\GenerateAttributesCommand\\:\\:configure\\(\\) has no return type specified\\.$#"
count: 1
Expand Down Expand Up @@ -12685,11 +12650,6 @@ parameters:
count: 1
path: engine/Shopware/Components/Acl.php

-
message: "#^Access to an undefined property Enlight_Controller_Response_Response\\:\\:\\$headers\\.$#"
count: 1
path: engine/Shopware/Components/AddLinkHeaderSubscriber.php

-
message: "#^Cannot call method setAcl\\(\\) on object\\|null\\.$#"
count: 1
Expand Down Expand Up @@ -14125,21 +14085,6 @@ parameters:
count: 1
path: engine/Shopware/Components/Cart/CartPersistService.php

-
message: "#^Query error\\: Column \"s_order_basket\\.currencyFactor\" expects value type float\\|int, got type mixed~0\\|0\\.0\\|''\\|'0'\\|array\\{\\}\\|false\\|null$#"
count: 1
path: engine/Shopware/Components/Cart/ConditionalLineItemService.php

-
message: "#^Query error\\: Column \"s_order_basket\\.sessionID\" expects value type string\\|null, got type mixed$#"
count: 1
path: engine/Shopware/Components/Cart/ConditionalLineItemService.php

-
message: "#^Query error\\: Column \"s_order_basket_attributes\\.basketID\" expects value type int\\|null, got type int\\|string\\|false$#"
count: 1
path: engine/Shopware/Components/Cart/ConditionalLineItemService.php

-
message: "#^Parameter \\#4 \\$path of class Symfony\\\\Component\\\\HttpFoundation\\\\Cookie constructor expects string\\|null, string\\|false given\\.$#"
count: 1
Expand Down Expand Up @@ -17956,47 +17901,12 @@ parameters:
path: engine/Shopware/Components/Plugin/Configuration/ReaderInterface.php

-
message: "#^Method Shopware\\\\Components\\\\Plugin\\\\CronjobSynchronizer\\:\\:addCronjob\\(\\) has no return type specified\\.$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Method Shopware\\\\Components\\\\Plugin\\\\CronjobSynchronizer\\:\\:addCronjob\\(\\) has parameter \\$cronjob with no value type specified in iterable type array\\.$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Method Shopware\\\\Components\\\\Plugin\\\\CronjobSynchronizer\\:\\:removeNotExistingEntries\\(\\) has no return type specified\\.$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Method Shopware\\\\Components\\\\Plugin\\\\CronjobSynchronizer\\:\\:removeNotExistingEntries\\(\\) has parameter \\$cronjobActions with no value type specified in iterable type array\\.$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Method Shopware\\\\Components\\\\Plugin\\\\CronjobSynchronizer\\:\\:synchronize\\(\\) has no return type specified\\.$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Method Shopware\\\\Components\\\\Plugin\\\\CronjobSynchronizer\\:\\:synchronize\\(\\) has parameter \\$cronjobs with no value type specified in iterable type array\\.$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Query error\\: Argument \\#1 is not a constant array, got array\\<mixed~'active', mixed\\>&hasOffsetValue\\('pluginID', int\\)$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Query error\\: Argument \\#1 is not a constant array, got hasOffsetValue\\('end', DateTime\\)&hasOffsetValue\\('next', DateTime\\)&hasOffsetValue\\('pluginID', int\\)&non\\-empty\\-array$#"
message: "#^Query error\\: Argument \\#1 is not a constant array, got array\\<string, mixed\\>&hasOffsetValue\\('pluginID', int\\)$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

-
message: "#^Query error\\: Column \"s_crontab\\.id\" expects value type int, got type mixed~0\\|0\\.0\\|''\\|'0'\\|array\\{\\}\\|false\\|null$#"
message: "#^Query error\\: Argument \\#1 is not a constant array, got non\\-empty\\-array\\<string, mixed\\>&hasOffsetValue\\('end', DateTime\\)&hasOffsetValue\\('next', DateTime\\)&hasOffsetValue\\('pluginID', int\\)$#"
count: 1
path: engine/Shopware/Components/Plugin/CronjobSynchronizer.php

Expand Down
2 changes: 1 addition & 1 deletion UPGRADE-5.7.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ This changelog references changes done in Shopware 5.7 patch versions.
* Updated `symfony/polyfill-php82` to version 1.31.0
* Updated `symfony/polyfill-php83` to version 1.31.0
* Updated `symfony/http-kernel` to version 4.4.51
* Updated `symfony/serializer` to version 5.4.44
* Updated `symfony/serializer` to version 5.4.45
* Updated `voku/anti-xss` to version 4.1.42
* Updated `wikimedia/less.php` to version 5.1.1
* Updated several indirect dependencies
Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@
"friends-of-behat/mink-extension": "2.7.5",
"php-parallel-lint/php-var-dump-check": "^0.5",
"phpstan/extension-installer": "1.4.3",
"phpstan/phpstan": "1.12.0",
"phpstan/phpstan-doctrine": "1.5.3",
"phpstan/phpstan-phpunit": "1.4.0",
"phpstan/phpstan-symfony": "1.4.11",
"phpstan/phpstan": "1.12.10",
"phpstan/phpstan-doctrine": "1.5.6",
"phpstan/phpstan-phpunit": "1.4.1",
"phpstan/phpstan-symfony": "1.4.12",
"phpunit/phpunit": "^9.6",
"sensiolabs/behat-page-object-extension": "2.3.7",
"staabm/phpstan-dba": "0.2.81",
Expand Down
Loading

0 comments on commit 4f305a5

Please sign in to comment.