fix: Remove superfluous if checks

shopware5 · Aug 19, 2024 · 5986a84 · 5986a84
1 parent 208b294
commit 5986a84
Showing 1 changed file with 15 additions and 19 deletions.
diff --git a/tests/Functional/Bundle/CustomerSearchBundleDBAL/TestCase.php b/tests/Functional/Bundle/CustomerSearchBundleDBAL/TestCase.php
@@ -126,20 +126,18 @@ protected function createCustomer(array $customer)
         unset($customerData['addresses'], $customerData['orders'], $customerData['newsletter']);
         $customerId = $this->insert('s_user', $customerData);
 
-        if (\array_key_exists('addresses', $customer)) {
-            foreach ($customer['addresses'] as $address) {
-                $address['user_id'] = $customerId;
-                $addressId = $this->insert('s_user_addresses', $address);
-
-                $this->connection->update(
-                    's_user',
-                    [
-                        'default_billing_address_id' => $addressId,
-                        'default_shipping_address_id' => $addressId,
-                    ],
-                    ['id' => $customerId]
-                );
-            }
+        foreach ($customer['addresses'] as $address) {
+            $address['user_id'] = $customerId;
+            $addressId = $this->insert('s_user_addresses', $address);
+
+            $this->connection->update(
+                's_user',
+                [
+                    'default_billing_address_id' => $addressId,
+                    'default_shipping_address_id' => $addressId,
+                ],
+                ['id' => $customerId]
+            );
         }
 
         if (\array_key_exists('orders', $customer)) {
@@ -159,11 +157,9 @@ protected function createCustomer(array $customer)
                 $order['userID'] = $customerId;
                 $orderId = $this->insert('s_order', $order);
 
-                if (\array_key_exists('details', $order)) {
-                    foreach ($order['details'] as $detail) {
-                        $detail['orderID'] = $orderId;
-                        $this->insert('s_order_details', $detail);
-                    }
+                foreach ($order['details'] as $detail) {
+                    $detail['orderID'] = $orderId;
+                    $this->insert('s_order_details', $detail);
                 }
             }
         }