feat(shorebird_cli): call flutter precache when installing new flutter rev
#2087
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main shorebirdtech/shorebird#2087 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 180 180
Lines 5516 5526 +10
=========================================
+ Hits 5516 5526 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bryanoltman
changed the title
flutter precache when installing new flutter rev
| precacheProgress.fail('Failed to precache Flutter $version'); | ||
| logger.info( | ||
| '''This is not a critical error, but your next build make take longer than usual.''', | ||
| ); |
There was a problem hiding this comment.
minor but maybe we can consolidate these into a single log like:
precacheProgress.fail('Failed to precache Flutter $version -- the next build make take longer than usual. ');There was a problem hiding this comment.
I wanted to have a part of the message that wasn't a "failure" or "error" message to head off support requests when/if this fails (just to be extra clear that the thing that went wrong isn't going to cause shorebird to not work)
| ); | ||
|
|
||
| try { | ||
| await process.run( |
There was a problem hiding this comment.
What about initial install? Should we also do this as part of the install script for consistency?
There was a problem hiding this comment.
Good idea, filed https://github.com/shorebirdtech/shorebird/issues/2093
Description
This provides better visibility into Flutter artifact downloads and why builds take as long as they do.
Type of Change