Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SG-31927 Flaky Test In python-api Test Work schedule #310

Merged
merged 3 commits into from
Oct 11, 2023
Merged

SG-31927 Flaky Test In python-api Test Work schedule #310

merged 3 commits into from
Oct 11, 2023

Conversation

NorberMV
Copy link
Contributor

@NorberMV NorberMV commented Oct 9, 2023 •
edited
Loading

Removing a flaky assertion that compares two calls to work_schedule_read() with the same parameters, as it serves no clear purpose and occasionally fails in the CI. Running this same test by making real calls to the python-api correctly returns the WorkDayRules defined between the given start_date and end_date.

carlos-villavicencio-adsk
carlos-villavicencio-adsk approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :shipit:

@NorberMV NorberMV merged commit 4a8b26f into master Oct 11, 2023
20 checks passed
@NorberMV NorberMV deleted the SG-31927_Flaky_test_in_python_api_test_work_schedule branch October 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-villavicencio-adsk carlos-villavicencio-adsk carlos-villavicencio-adsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NorberMV @carlos-villavicencio-adsk