SG-33891 Retries also on 504 #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
previously approved these changes
Dec 18, 2023
| @@ -3443,8 +3443,8 @@ def _call_rpc(self, method, params, include_auth_params=True, first=False): | |||
| # We've seen some rare instances of SG returning 502 for issues that | |||
| # appear to be caused by something internal to SG. We're going to | |||
| # allow for limited retries for those specifically. | |||
| if attempt != max_attempts and e.errcode == 502: | |||
| LOG.debug("Got a 502 response. Waiting and retrying...") | |||
| if attempt != max_attempts and e.errcode in [502, 504]: | |||
There was a problem hiding this comment.
You might want to use HTTPStatus constants instead: http.HTTPStatus.SERVICE_UNAVAILABLE and http.HTTPStatus.GATEWAY_TIMEOUT
Not a blocker but it's usually better to use constants.
There was a problem hiding this comment.
I know. However, this would imply a full rewrite of the python-api and we can address that in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.