SG-34197 Retry S3 uploads on error 500 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carlos-villavicencio-adsk
commented
Jan 26, 2024
carlos-villavicencio-adsk
commented
- Follow up work from SG-20154 Add Retries on 503 Errors when uploading to S3 in Shotgun python-api #263
- Include error 500s retries when uploading to S3 cloud
carlos-villavicencio-adsk
changed the title
julien-lang
previously approved these changes
Jan 26, 2024
shotgun_api3/shotgun.py
Outdated
| if e.code == 503: | ||
| raise ShotgunError("Got a 503 response when uploading to %s: %s" % (storage_url, e)) | ||
| if e.code in [500, 503]: | ||
| raise ShotgunError("Got a %s response when uploading to %s: %s" % (e.code, storage_url, e)) |
There was a problem hiding this comment.
Minor non-blocking point, the code could be easier to read this way IMO:
if attempt != max_attempts and e.code in [500, 503]:
LOG.debug("Got a %s response. Waiting and retrying..." % e.code)
time.sleep(float(attempt) * backoff)
attempt += 1
continue
elif e.code in [500, 503]:
raise ShotgunError("Got a %s response when uploading to %s: %s" % (e.code, storage_url, e))
else:
raise ShotgunError("Unanticipated error occurred uploading to %s: %s" % (storage_url, e))
carlos-villavicencio-adsk
deleted the
ticket/SG-34197_retry_s3_upload_on_500
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.