-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG-34910 Fixup SSLEOFError exception #346
Conversation
e626ed4
to
f9f50d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# the connection and make a new attempt. | ||
LOG.debug("SSLEOFError: {}".format(e)) | ||
self._close_connection() | ||
if attempt == max_rpc_attempts: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.config.max_rpc_attempts
is hardcoding the value of 3
. Maybe we can now get rid of this one and use self.MAX_ATTEMPTS
instead. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded yes and no. It's the default value of the config object but users can select a different value.
Also, I see that this variable is still used at other places. So I kind of want to keep it as is for the moment.
Use the existing re-attempt strategy in case of SSLEOFError