Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG-35018 Remove Ticket entity reference and prepare this to run in CI #349

Merged

Conversation

carlos-villavicencio-adsk
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk commented Jun 14, 2024

Ticket entity is disabled by default on ShotGrid (it seems so).

image

I'm making unit tests dependant-free on this entity. It seems they were enabled when these tests were implemented, but now this is making it harder to test locally with fresh SG sites.

filters = [['sg_priority', 'in', self.ticket['sg_priority'], '1'],
['project', 'is', self.project]]

result = self._id_in_result('Ticket', filters, self.ticket['id'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not equivalent with Version on these ones ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I just replaced them and got these tests back. Thank you!

@carlos-villavicencio-adsk carlos-villavicencio-adsk changed the title SG-35018 Remove Ticket entity related tests SG-35018 Remove Ticket entity reference and prepare this to run in CI Jun 19, 2024
Copy link
Contributor

@julien-lang julien-lang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit fc9eff1 into master Jun 19, 2024
24 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-35018_remove_Ticket_entity_tests branch June 19, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants